ci(tooling): verify scripts/check-tools.sh runs successfully in CI - #519
Open
maisamariwanta4-bit wants to merge 1 commit into
Open
Conversation
Add a step to the init-smoke-test workflow that runs scripts/check-tools.sh to verify the CI environment's toolchain (Rust 1.95.0 and stellar-cli 22.8.2) and wasm32-unknown-unknown target are correctly installed and accessible. Also update the workflow trigger paths to include scripts/check-tools.sh so the workflow runs whenever the script is modified, catching any regressions in the verification script itself before they affect contributor experience.
|
@maisamariwanta4-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CI verification that scripts/check-tools.sh runs successfully to ensure the environment verification script itself doesn't regress.
Description
The check-tools.sh script verifies that the development environment has the correct versions of Rust, stellar-cli, and the wasm32-unknown-unknown target installed. Previously, this script was only run manually by contributors and never exercised by CI, meaning any regressions in the script itself (like from version pin bumps) wouldn't be caught automatically.
This PR adds a new step to the init-smoke-test workflow that runs check-tools.sh after installing the pinned toolchain versions, confirming it correctly validates the CI environment.
Changes
scripts/check-tools.shscripts/check-tools.shso the workflow runs whenever the script changesTesting
The check-tools.sh script will verify:
All of these are installed by preceding CI steps, so the verification should pass.
closes #433